You most likely have a problem because you don't quote the file names:

    for f in "*/*.bmp" ; do convert $f "${f%bmp}png" ; done
    #        ^       ^                 ^           ^
do this so the space in the file names do not cause problems.