filenames with ' in, (we're) is messing with my script

Question

I have a script that first move the selected files into a temp directory,scans the directory, takes the largest file and create a new directory with that name, and moving all files to the newly created directory.

but it's crashing when bumping into directories or files containing the ' character, for example the word we're I think it can have something to do with the jfilenameall isn't "quoted" right, and I have tested a few ways, but haven't got it to work.

anybody that knows what I'm doing wrong?

Worth mention is that I'm running this script Via nemo action, so the following command line is executed: script.sh "path/filename1.txt" "path/filename2.txt" ..and so on depending on how many files that was selected in the gui

jdir2="$1"
jdirfirst="${jdir2%/*}"
jdir="$jdirfirst"/
jdir0="$jdirfirst"
tmpdir="$jdir0/tmp.tmp3"
mkdir "$tmpdir"
mv "$1" "$2" "$3" "$4" "$5" "$6" "$7" "$tmpdir"/
                
 jfilenameall=$(basename $(find $tmpdir -maxdepth 1 -type f  -printf "%s\t%p\n" | sort -n | tail -1 | awk '{print $NF}'))
jfilename="${jfilenameall::-4}"
jfilenameextension="$(echo -n $jfilenameall | tail -c 3)"
jfilename=${jdirlast::-4}    
mkdir "$jdir0/$jfilename"
mv "$jdir0/tmp.tmp3/"* "$jdir0/$jfilename/"

Answer 1

This will do what your question describes (I removed some of the steps you had since they didn't seem necessary). Note that it assumes you are using GNU tools. The main issue was that you weren't double quoting your variables and command substitutions. I also made this work for some weirder file names such as those containing newlines or those starting with -:

#!/bin/bash

## You don't define $jdir0 in your script, so I am assuming you
## do so earlier. I'm setting it to '/tmp' here.
jdir0="/tmp"

## Create a temp dir in $jdir0
tmpdir=$(mktemp -dp "$jdir0")

## Move all arguments passed to the script to the tmp dir,
## this way you don't need to specify $1, $2 etc. The -- ensures
## this will work even if your file names start with '-'.
mv -- "$@" "$tmpdir"/


## Get the largest file's name. Assume GNU find; deal with arbitrary file names,
## including those with spaces, quotes, globbing characters or newlines
IFS= read -r -d '' jfilenameall < <(find "$tmpdir" -maxdepth 1 -type f \
                                        -printf '%s\t%p\0' | sort -zn |
                                        tail -zn1 | cut -f 2-)

## Assume GNU find; deal with arbitrary file names, including those with
## spaces, quotes, globbing characters or newlines
jfilenameall="$(basename "$jfilenameall")"

## Get the extension: whatever comes after the last . in the file name. You don't
## use this anywhere, but maybe you just don't show it. If the file has no extension,
## this variable will be set to the entire file name.
jfilenameextension="${jfilenameall##*.}"

## get the file name without the extension. Don't assume an extension will always be 3 chars
jfilename="${jfilenameall%.*}"

## You don't define $jdir0 in your script. I am assuming you do so earlier
mkdir -p "$jdir0/$jfilename"
mv -- "$tmpdir/"* "$jdir0/$jfilename/"

## remove the now empty tmp dir
rmdir "$tmpdir"