Making simple BASH Shell script that takes two arguments, checks them, then copies the first (file) argument to the second (directory) argument

Question

I have started a few days ago learning how to make scripts in shell. How can I make script thaht takes two arguments ( file name and some directory), if arguments are bad I want to make error alert and if they are correct I want to copy file in given directory? so far I made this:

#!/bin/bash
if [ -d $1 ] ; then
 ???
 done
else
 echo $1 NOT DIRECTORY
 exit 1
fi

And separate I made a part for checking a file. How to put this together ?

#!/bin/bash
if [ $# -ne 1 ]
then
 echo "Use- $0 file"
 exit 1
fi
if [ -f $1 ]
then
 echo "$1 There is no file with that name"
else
 echo "$1 There is no file with that name"
fi

I am new to bash script so I would like to get some help.

Answer 1

You can use a tructure like this:

• First check the number of arguments is right, in this case 2

  if arguments not 2
    message "Not enough arguments" and exit
  

• Check that arguments are valid file and directory.

  if argument1 not a file
    message "Not af file" and exit
  
  if argument2 not a directory
    echo "Not a directory" and exit
  

• If both arguments are correct, perform the copy:

  message "Copying file"
  copy file to directory
  

Remember to exit in case of error, so the script doesn't keep running.

You can also use one liners instead of the if's:

[[ ! -f "$1" ]] && echo "Not a file" && exit