Touch Command not working in bash for some reason

Question

Something as simple as this is working surely

#!/bin/bash
touch /sdcard/successful.txt

But its not working in my actual bash command

#!/bin/bash
PACKAGE='com.mixplorer'
if [ $(pidof $PACKAGE) ]; then
  am force-stop com.mixplorer && am start -n com.mixplorer/.activities.BrowseActivity
fi

if [ ! $(pidof $PACKAGE) ]; then
  am start -n com.mixplorer/.activities.BrowseActivity
fi

loopcleaner()
{
  rm -rf /sdcard/log.txt
}

while [ $(pidof $PACKAGE) ]
do
  loopcleaner
  sleep 2

  if [ ! $(pidof $PACKAGE) ]; then
    touch /sdcard/successful.txt
    exit 0;
  fi
done

Explanation:

1. As soon as script is executed , first check if file manager with package name 'com.mixplorer' is active If yes , then force stop it and open it again If no , then just simply open it.

2. Now that the file manager is already opened , keep deleting a file named 'log.txt' as defined by loopcleaner every 10 seconds in a loop forever as long as file manager process is running.

3. The above cleaning activity should work only till file manager process is running , Once it stops create a file named successful.txt .Script should end immediately now.

So after i have exited my file manager , the successful.text doesn't gets created in my internal storage for some reason ( which works well if simply touch command is executed )

Answer 1

I fixed it by adding a break after my touch command.

while [ $(pidof $PACKAGE) ]
do
  loopcleaner
  sleep 2

  if [ ! $(pidof $PACKAGE) ]; then
    touch /sdcard/successful.txt
    break
    exit 0;
  fi
done

( although i am very much new to bash and not really confident of myself if this this is the best approach so any further edit/ suggestions to improve it will be lot appreciated )

Answer 2

In my case we had a touch bash alias function defined as touch -a "$@" which was only updating the access time instead of (in addition to) the modification time.

By default touch will update both of these times, but our bash function was overriding that.

Simply changing the function to touch -am "$@" fixed the problem.