Unix & Linux Stack Exchange is a question and answer site for users of Linux, FreeBSD and other Un*x-like operating systems. It only takes a minute to sign up.
Sign up to join this community
On his web page about the self-pipe trick, Dan Bernstein explains a race condition with select() and signals, offers a workaround and concludes that
Of course, the Right Thing would be to have
fork()return a file descriptor, not a process ID.
What does he mean by this -- is it something about being able to select() on child processes to handle their state changes instead of having to use a signal handler to get notified of those state changes?
The problem is described there in your source, select() should be interrupted by signals like SIGCHLD, but in some cases it doesn't work that well. So the workaround is to have signal write to a pipe, which is then watched by select(). Watching file descriptors is what select() is for, so that works around the problem.
The workaround essentially turns the signal event into a file descriptor event. If fork() just returned an fd in the first place, the workaround would not be required, as that fd could then presumably be used directly with select().
So yes, your description in the last paragraph seems right to me.
Another reason that an fd (or some other kind of a kernel handle) would be better than a plain process id number, is that PIDs can get reused after the process dies. That can be a problem in some cases when sending signals to processes, it might not be possible to know for sure that the process is the one you think it is, and not another one reusing the same PID. (Though I think this shouldn't be a problem when sending signals to a child process, since the parent has to run wait() on the child for its PID to be released.)
wait().
clone, which is the actual system call that fork invokes on LInux. The flag to enable this is called CLONE_PIDFD - See for example lwn.net/Articles/784831.
Jul 21, 2019 at 7:44
Bernstein doesn't give much context for this "Right Thing" remark, but I'll hazard a guess: having fork(2) return a PID is inconsistent with open(2), creat(2) etc returning file descriptors. The rest of the Unix system could have done process manipulation with a file descriptor representing a process, instead of a PID. A system call signalfd(2) exists, which allows a somewhat better interaction between signals and file descriptors, and shows that a file-descriptor-representing a process could work out.
pidfd_open as well in Linux, see for example lwn.net/Articles/789023
It's just a musing on the lines of "it would be great if Unix was designed differently than it is".
The problem with PIDs is that they live in a global namespace where they could be reused for another process, and it would be nice if fork() returned in the parent some kind of handle that would be guaranteed to always refer to the child process, and that it could pass to other processes via inheritance or unix sockets / SCM_RIGHTS[1].
See also the discussion here for a recent effort to "fix" that in Linux, including adding a flag to clone() which will cause it to return a pid-fd instead of a PID.
But even then, that would not eliminate the need for that self-pipe hack [2] or better interfaces, since the signals notifying a parent process about the state of a child are not the only ones you would like to handle in the main loop of the program. Unfortunately, things like epoll(7) + signalfd(2) on Linux or kqueue(2) on BSD are not standard -- the only standard interface (but not supported on older systems) is the much inferior pselect(2).
[1] Preventing the PID from being re-cycled by the time the waitpid() syscall had returned and its return value was used could probably be achieved on newer systems by using waitid(.., WNOWAIT) instead.
[2] I would not comment on D.J. Bernstein claim that he invented it (sorry for the apophasis ;-)).
The point is that there are many programs that operate an event-loop style model based around monitoring file descriptors with select(2)/poll(2)/epoll(7). But there were various events that historically didn't notify using file descriptors--among them process state transition (e.g., termination) of a child process. The need to separately handle these other events (which include timer expirations, signals, and synchronization events such as semaphore changes) complicated programming of the event-loop model.
In the last several years, Linux development has been chipping away at this problem, so that nowadays we have signalfd(2) (make signals readable from a file descriptor), eventfd(2) (a synchronization primitive whose handle is a file descriptor), and timerfd_create(2) (create timers that notify via a file descriptor), all of which produce file descriptors that can be fed to select(2)/poll(2)/epoll(7).
And finally, recent versions of Linux have added the concept of a handle for a process as a file descriptor. The CLONE_PIDFD flag of clone3() can be used to create a child process for which a file descriptor as handle is returned. The file descriptor can likewise be fed to select(2)/poll(2)/epoll(7) and indicates as readable if the the child process terminates.
signalfds and such were a thing back then?wait(), there were things you couldn't do, so someone invented SIGCHLD, but it was a bad job. In my experience, and now that they exist, sprinkling nice, nonblockingwait3(),wait4(), and/orwaitpid()calls at key places (perhaps your main event loop) is a vastly superior alternative.