Bash Script - case esac - fails

Question

Is the following script right??? It was doing OK until yesterday!

I've written the following script to help a cron job running every minute and calling some other script which may cause a command to be executed more than once, the expected behaviour is to have 4 process of the job, anything less or more should be causing a restart, so please let me know if the following script is right or not?

#! /bin/bash

case "$(pidof command | wc -w)" in

0)  echo "Restarting command:     $(date)" >> log

    /usr/bin/sh x.sh
    ;;

4)  # all ok

    echo "All OK" >> log
    ;;

*)  for pid in $(ps -ef | grep "x" | grep "y" | awk '{print $2}'); do kill -9 $pid; done

    echo "Removed PIDs and RESTARTING FFMPEG: $(date)" >> /root/afarinEidSTs/log

    /usr/bin/sh x.sh
    ;;

esac

It will not kill proccesses even if they get more than 4, why?

In log file, I will just see the result of "Restarting command: $(date)".

It is so weird, because pidof ffmpeg | wc -w will display 23, but the script is not killing all and restarting them again!

---

I have also tried using ([0-3]) instead of 0) as @jordanm said, but didn't help.

Answer 1

It's probably because your cron or something that you are using for doing your jobs, cannot execute all commands you have used. To fix the issue, I recommend you use the the bsolute path of any command - taken by using which pidof, which grep &c :

#!/bin/bash

case "$(/usr/sbin/pidof command | /usr/sbin/wc -w)" in

0)  echo "Restarting command:     $(date)" >> log

    /usr/bin/sh x.sh
    ;;

4)  # all ok

    echo "All OK" >> log
    ;;

*)  for pid in $(/usr/sbin/ps -ef | /usr/sbin/grep "x" | /usr/sbin/grep "y" | /usr/sbin/awk '{print $2}'); do kill -9 $pid; done

    echo "Removed PIDs and RESTARTING FFMPEG: $(date)" >> /root/afarinEidSTs/log

    /usr/bin/sh x.sh
    ;;

esac

Double check full paths in your system.