1

I'm using a solution described here to log my shell sessions, by adding this to the end of /etc/bash.bashrc:

test "$(ps -ocommand= -p $PPID | awk '{print $1}')" == 'script' || (script -f /var/log/shellog/$USER-$(date -u +%Y.%m.%d-%H:%M:%S).${HOSTNAME:-$(hostname)}.$$.log)

This works fine, however, when I exit the shell, I have to exit twice: once from the script, and once from the shell:

Last login: Wed Aug  6 12:43:29 2014 from *****
Script started, file is /var/log/shellog/camilstaps-2014.08.06-10:43:40.cs.localdomain.16048.log
camilstaps@cs:/$ exit
exit
Script done, file is /var/log/shellog/camilstaps-2014.08.06-10:43:40.cs.localdomain.16048.log
camilstaps@cs:/$ exit
exit

I found this, and tried modifying the line in /etc/bash.bashrc accordingly, but this doesn't change anything:

test "$(ps -ocommand= -p $PPID | awk '{print $1}')" == 'script' || (script -f /var/log/shellog/$USER-$(date -u +%Y.%m.%d-%H:%M:%S).${HOSTNAME:-$(hostname)}.$$.log && exit)

I suppose it's because I have to test that I'm not in script already (without the test it keeps making new scripts). But how can I make that I don't have to exit twice?

  • What does ps -ocommand= -p $PPID return ? – Valentin Bajrami Aug 6 '14 at 11:11
  • @val0x00ff script -f /var/log/shellog/camilstaps-2014.08.06-11:12:11.cs.localdomain.16164.log – user37050 Aug 6 '14 at 11:12
  • so that will always match. With awk you are printing the first field which is script. Everything after || will never get executed. – Valentin Bajrami Aug 6 '14 at 11:16
  • 1
    @val0x00ff that works! Thank you very much. I don't understand why exactly, but I'll try to figure it out. Could you add it as an answer? – user37050 Aug 6 '14 at 11:25
  • 1
    Camil, the command you had within () will run in a subshell. This means another process is created. Read more about it here: mywiki.wooledge.org/SubShell – Valentin Bajrami Aug 6 '14 at 11:31
0

As requested. The following should work

[[ $(ps -ocommand= -p $PPID | awk '{print $1}') = script ]] || { script -f /var/log/shellog/$USER-$(date -u +%Y.%m.%d-%H:%M:%S).${HOSTNAME:-$(hostname)}.$$.log && exit ;} 

Your Answer

By clicking “Post Your Answer”, you agree to our terms of service, privacy policy and cookie policy