9

I'm running a script that relies on network being up and a network share be mounted. The script runs on login (which happens automatically after boot). The problem is that by the time the script runs, I usually do not have an IP address yet (DHCP). At the moment I just sleep the script for 15s, but I don't like this approach at all, since I want to be able to tell the user if something is wrong.

What my plan is, is loop while I don't have an IP address yet and continue when I do. Crucially, it has to time out after a while. What I came up with is to if [ ifconfig | grep "192.168.100" ]; but what happens is that grepconsumes the ]; and doesn't like it. Then bash also gets upset, because it can't find the ]; which grep ate. And then I haven't even implemented the time-out.

Someone suggested keeping a variable, and sleeping for, say, a second in each iteration and increase this variable each time. Here is my complete (non working) script (I'm fairly new to bash scripting):

x=0
while [ ifconfig | grep "192.168.100." > /dev/null ]; do
    echo "no nework"
    if "$x" -gt 200; then
        #Time out here
        exit 1
    x=$((x+1))
    sleep .1
    fi
done

#continue with rest of script...

Any pointers in the right direction would be greatly appreciated!

  • 1
    If your init is systemd, write a service file that waits for network-online.target... – jasonwryan Jul 28 '14 at 17:20
  • no need to redirect grep output to /dev/null. Use -q option instead. And also I don't thing grepping ifconfig is a good idea. Why not to use ping instead? – rush Jul 28 '14 at 17:32
  • ping can fail depending on the network in question. It's better to just check the system's running configuration. – Bratchley Jul 28 '14 at 18:00
8

Shell syntax

You seem to be confused regarding conditionals in shell scripts. Every shell command has an exit status, which is an integer between 0 and 255, with 0 meaning success and any other value meaning failure. Statements like if and while that expect boolean operands inspect the exit status of the command and treat 0 (success) as true and any other value (failure) as false.

For example, the grep command returns 0 if the pattern is found and 1 if the pattern is not found. So

while ifconfig | grep "192.168.100." > /dev/null; do …

repeats the loop as long as the pattern 192.168.100. is found in the output of ifconfig. Note that the pattern 192.168.100. matches strings like 192x168 1007, because . in a regular expression matches any character; to search for a literal string, pass the option -F to grep. To invert the condition, put ! in front.

while ! ifconfig | grep -F "192.168.100." > /dev/null; do …

Further in the script, you want to compare the value of a variable to a number. You use the -gt operator, which is part of the syntax of the of conditional expressions understood by the test command. The test command returns 0 if the conditional expression is true and 1 if the conditional expression is false.

if test "$x" -gt 200; then

It is customary to use the alternate name [ for the test command. This name expects the command to end with the parameter ]. The two ways of writing this command are exactly equivalent.

if [ "$x" -gt 200 ]; then

Bash also offers a third way to write this command, with the special syntax [[ … ]]. This special syntax can support a few more operators than [, because [ is an ordinary command subject to the usual parsing rules, while [[ … ]] is part of the shell syntax.

Again, keep in mind that [ is for conditional expressions, which are a syntax with operators like -n, -gt, … [ doesn't mean “boolean value”: any command has a boolean value (exit status = 0?).

Detecting that the network is up

Your way of detecting that the network is up is not robust. In particular, note that your script will be triggered as soon as any network interface acquires an IP address within the specified range. In particular, it's quite possible that DNS won't be up yet at that point, let alone any network shares mounted.

Do you really need to run these commands when someone logs in? It's easier to make a command run automatically when the network is brought up. The way to do that depends on your distribution and whether you use NetworkManager.

If you need to run these commands as part of the login scripts, then test for the resource that you really need, not for the presence of an IP address. For example, if you want to test whether /net/somenode/somedir is mounted, use

while ! grep -q /net/somenode/somedir </proc/mounts; do
  sleep 1
done

If you have upstart or systemd…

then you can use it. For example, with Upstart, mark your job as start on net-device-up eth0 (replace eth0 by the name of the interface that provides the desired network connectivity). With Systemd, see Cause a script to execute after networking has started?

  • I guess /net/ should be /proc/net? – sebix Mar 1 '15 at 18:07
  • @sebix No, why would it? I'm not talking about Linux's network configuration. I'm giving an example of a mount point for a remote filesystem, /net is a common location for such mount points. – Gilles 'SO- stop being evil' Mar 1 '15 at 19:40
  • Ok, so you require a mounted network drive. Does a more generic solution also exist? – sebix Mar 1 '15 at 20:05
  • @sebix A solution for what? Requiring a mounted network drive was an example of a goal, not an example of a solution. – Gilles 'SO- stop being evil' Mar 1 '15 at 20:42
1

Just count the output of ip add show For example:

root@xxxxxxlp01 ~ $ ip add sh dev eth3 | grep inet
root@xxxxxxlp01 ~ $ ip add sh dev eth1 | grep inet
root@xxxxxxlp01 ~ $ ip add sh dev eth0 | grep inet
    inet xxx.xxx.64.91/24 brd xxx.xxx.95.255 scope global eth0
    inet6 fe80::224:e8ff:fe78:4dfb/64 scope link
root@xxxxxxlp01 ~ $ ip add sh dev eth0 | grep inet | wc -l
2

Then you can just branch on the number of line returned as appropriate. You'd probably just check whether it was zero, and if so, sleep and repeat the loop.

Untested code for illustration:

while [ 1 ]; do

  if [ $(ip add sh dev eth0 | grep inet | wc -l) -ne 0 ]; then
     break
  fi

  sleep 1

done
1

Ping will return a 0 response if at least one attempt was successful. You might consider pinging the server you are connecting to until it is successful.

Your Answer

By clicking “Post Your Answer”, you agree to our terms of service, privacy policy and cookie policy

Not the answer you're looking for? Browse other questions tagged or ask your own question.