copy files from one path to another path in linux

Question

I am trying to copy files from one path to another path. I have a text file which has all names of files in the following pattern:

file-1.txt
file-2.pdf
file-3.ppt
....

I created a .sh file with the following code:

 #!/bin/bash
file=`cat filenames.txt`;
fromPath='/root/Backup/upload/';
toPath='/root/Desktop/custom/upload/';
for i in $file;
do
 filePath=$fromPath$i
 #echo $filePath
 if [ -e $filePath ];
 then
   echo $filePath
   yes | cp -rf $filePath $toPath
 else
   echo 'no files'
 fi
done

The above code is copying only the last file name from the text instead of all to the destination path.

Answer 1

file=/path/to/filenames.txt
fromPath=/root/Backup/upload/
toPath=/root/Desktop/custom/upload/

cd "$fromPath" && xargs mv -t "$toPath" < "$file"

Answer 2

You might take a look at rsync, if you're not already familiar with it. This looks like a problem that shouldn't really require a script of its own.

Take a look here, or use your Google foo.

The rsync option you need is probably --files-from.

The rsync incantation will be something like:

rsync --files-from filenames.txt /root/Backup/upload /root/Desktop/custom/upload